fix: platform constants is undefined on web #4257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
in #4246 a check based on react native version was introduced, however the
Platform.constants
property isundefined
when targetting web using thereact-native-web
approach listed in the docs, as the platform object is simply:adjust it to check if the
OS
isweb
and use the native driver as before if so.whilst I'm not totally sure whether using the "native driver" is the best option on web, until #4246 this was the case, so seemed the best option to revert to.
Interim Workaround
In the meantime, rather than monkey patching
react-native-paper
I'm working around by monkey patching the constants like so:I'm using
expo-router
so have placed this in my general app initialization effect in the root layout.Test plan
Before this change, I encounter this error:
Afterwards the error is gone, and the buttons look correct to my eyes.